fix(docker): honor configured supervisor image#1935
Conversation
|
🌿 Preview your docs: https://nvidia-preview-pr-1935.docs.buildwithfern.com/openshell |
|
Label |
|
Label |
PR Review StatusValidation: this is maintainer-authored, project-valid Docker e2e and SSH environment stabilization work. It keeps local Docker e2e aligned with the configured supervisor image and prevents host linker variables from breaking the external OpenSSH process while preserving the proxy child environment. Review findings:
Docs: relevant Docker supervisor image behavior is reflected in the Docker driver README and Next state: |
Re-check After CI UpdateI re-evaluated latest head Disposition: not resolved. Remaining items:
Next state: |
BlockedGator is blocked by merge conflicts with the base branch. GitHub reports Next action: @elezar, please rebase or merge the base branch and resolve the conflicts, then push an updated head so gator can re-check review state and CI. |
Re-check After Author UpdateI re-evaluated latest head Disposition: partially resolved. Remaining items:
Next state: |
Maintainer Approval NeededGator validation and PR monitoring are complete. Validation: maintainer-authored, project-valid local Docker e2e and SSH environment stabilization work. Human maintainer approval or merge decision is now required. |
Re-check After Author UpdateI re-evaluated latest head Disposition: partially resolved, but not ready to leave review. Remaining items:
Docs: relevant Docker supervisor image behavior remains covered in the Docker driver README and Next state: |
Re-check After CI UpdateI re-evaluated latest head Disposition: partially resolved, but not ready to leave review. Remaining items:
Next state: |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Re-check After Author UpdateI re-evaluated latest head Disposition: resolved. Remaining items:
Docs: relevant Docker supervisor image behavior is covered in the Docker driver README and Next state: |
Re-check After Author UpdateI re-evaluated latest head Disposition: resolved; no state change is needed. Remaining items:
Checks: Next state: |
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: the last gator state was I removed the active |
Summary
Fix the local Docker e2e path and Docker driver supervisor resolution so a configured
supervisor_imageis honored before local or sibling supervisor binaries. The Docker e2e wrapper now builds or pulls a supervisor image and writessupervisor_imageinto gateway TOML instead of generating a temporarysupervisor_binoverride.Related Issue
N/A
Changes
supervisor_bin, then configuredsupervisor_image, then sibling/local target binaries, then the default release-matched supervisor image.supervisor_imagewins over local supervisor binaries.e2e/with-docker-gateway.shto use the configured supervisor image path and buildopenshell/supervisor:devwhen no image override is provided.Testing
mise run pre-commitpassesNot rerun while updating this PR description.
Checklist